From: Thomas Gries <wikinaut@users.mediawiki.org>
Date: Sun, 5 Feb 2012 11:00:07 +0000 (+0000)
Subject: Please review carefully, I cannot see negative side effects from this patch. It gives... 
X-Git-Tag: 1.31.0-rc.0~24933
X-Git-Url: http://git.cyclocoop.org/%7D%7Cconcat%7B?a=commitdiff_plain;h=87ed9b37f24fea6ebc85b6da9083b3420cc796eb;p=lhc%2Fweb%2Fwiklou.git

Please review carefully, I cannot see negative side effects from this patch. It gives extensions which use the (depreacted) UnknownAction hook a chance to see the original action= value. This fixes bug 34203 and bug 34161 UnknownAction hook problem: the hook must pass the unknown action to the callee and not the value "nosuchaction"
---

diff --git a/includes/Wiki.php b/includes/Wiki.php
index 86883d9751..6ead57c4c9 100644
--- a/includes/Wiki.php
+++ b/includes/Wiki.php
@@ -486,7 +486,7 @@ class MediaWiki {
 			return;
 		}
 
-		if ( wfRunHooks( 'UnknownAction', array( $act, $page ) ) ) {
+		if ( wfRunHooks( 'UnknownAction', array( $request->getVal( 'action', 'view' ), $page ) ) ) {
 			$output->showErrorPage( 'nosuchaction', 'nosuchactiontext' );
 		}